Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugin_lang_defaulted() function to MantisBT core #339

Closed
dregad opened this issue Feb 27, 2020 · 2 comments
Closed

Move plugin_lang_defaulted() function to MantisBT core #339

dregad opened this issue Feb 27, 2020 · 2 comments
Labels
enhancement upstream
Milestone
2.5.0

Comments

@dregad
Copy link
Member

dregad commented Feb 27, 2020

#215 introduced a new plugin_lang_defaulted() function in Source.API.php.

As mentioned in #215 (comment) this function really belongs in MantisBT core / plugin_api.php so it should be moved there and eventually removed from the plugin's API.
@dregad
Copy link
Member Author

dregad commented Feb 27, 2020

Upstream tracking https://mantisbt.org/bugs/view.php?id=26747

@dregad
Copy link
Member Author

dregad commented Mar 15, 2020

Fixed in mantisbt/mantisbt@d92b78f.

The code in Source API can be removed and MantisCore minimum requirement bumped, when MantisBT 2.24.0 has been released.

@dregad dregad added this to the 2.5.0 milestone Mar 19, 2021
dregad added a commit that referenced this issue May 13, 2021
@dregad
Bump minimum MantisBT version to 2.24.0
c41d37c 
This is required so we can remove the plugin_lang_get_defaulted()
function, duplicated from plugin API (see #339).

Fixes #337
@dregad dregad closed this as completed in e346249 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement upstream
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@dregad