reduce docker image size by almost half #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit substantially reduces the size of the docker image by using multi-stage builds. This allows us to build the software in the first stage and copy the built artifacts into the second, final stage. We only install runtime dependencies into the second stage. We also use a python base image so that python/pip are already available in the image.
|
Hi Thanks for the suggestion. It is useful. I merged your version, but afterwards I changed it mainly for maintenance purposes. Now we use the multi-stage build, but the environment inside the docker image will be build based on the conda yml file. The resulted image is a bit bigger than the one you suggested, but it will be better long term. Vasilis |
manuel-munoz-aguirre
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thank you for making this package -- it's exactly what i need :)
This commit substantially reduces the size of the docker image by using
multi-stage builds. This allows us to build the software in the first
stage and copy the built artifacts into the second, final stage. We only
install runtime dependencies into the second stage. We also use a python
base image so that python/pip are already available in the image.