Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): only count successful opens #113

Merged
merged 1 commit into from
Sep 25, 2023
Merged

feat(core): only count successful opens #113

merged 1 commit into from
Sep 25, 2023

Conversation

manzt
Copy link
Owner

@manzt manzt commented Sep 25, 2023

  • Only count v2 vs. v3 for successful.
  • Adds additional tests for switching priority v2 vs. v3

@manzt
Copy link
Owner Author

manzt commented Sep 25, 2023

Added you as a collaborator @keller-mark, would you mind giving a review?

keller-mark
keller-mark approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@keller-mark keller-mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@manzt manzt merged commit 72eaa66 into main Sep 25, 2023
2 checks passed
@manzt manzt deleted the counter branch September 25, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keller-mark keller-mark keller-mark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manzt @keller-mark