Add option to return matrix of combinations between two vectors #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Fd-3741 It's included in v2.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to add new functionality in haversine_vector that returns a matrix with the distances between all combinations of coordinates.
To use this new functionality, the user must set the 'comb' argument to True. And the function will return the above-mentioned matrix instead.
As a bonus, the function will verify the shapes of both input vectors before proceeding if it's usage is with 'comb' as False. If the dimensions differ, the exception message also reminds the user of the new functionality.
The README file have a detailed description of the new functionality. I've included an example and a mathematical description to make it as clear as possible.
I've used this version in another project of mine and tested on it. Therefore I didn't alter the test files. The results written in README are real and can be used for such.