Use Local<> ubiquitously #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
seize-local
branch
from
a888a37
to
8f35aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32 -- all high-level methods that produce a local reference now use
Local<>. To enforce thisObject<>is no longer publicly constructible/destructible, though you can still useObject<>&. Native methods should accept object arguments by reference, and you'll need to add a reference toauto& klass = Class<T>::Singleton(env).Overall, this finally feels like the right solution to ownership compared to previous iterations (#30,
PointerToValue).Fixes #33 --
Object<Derived>&now converts toObject<Base>&via an inheritance relation. Needed this becauseObject<>is no longer publicly constructible, so you can't do the conversion manually.