Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only apply promoteId if sourceLayer specified #12322

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Only apply promoteId if sourceLayer specified #12322

merged 1 commit into from
Oct 20, 2022

Conversation

yongjun21
Copy link
Contributor

@yongjun21 yongjun21 commented Oct 20, 2022 •
edited by mourner
Loading

#12312 (comment)

<changelog>Fix a bug where setting promoteId for some layers broke feature ids on other layers.</changelog>

@yongjun21 yongjun21 requested a review from a team as a code owner October 20, 2022 14:22
@CLAassistant
Copy link

CLAassistant commented Oct 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mourner mourner merged commit cd11bcb into mapbox:main Oct 20, 2022
stepankuzmin pushed a commit that referenced this pull request Oct 24, 2022
@yongjun21 @stepankuzmin
Only apply promoteId if sourceLayer specified (#12322)
8ec4337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongjun21 @CLAassistant @mourner