Fix variable repurposing and out-of-order conditional #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `layer` variable was being used for both style layers and source layers. As a result, the fact that the `version === 1` conditional was being checked at the wrong point went unnoticed. The `if (layer)` conditional was also misplaced, but fortunately it didn't matter because the prior loop already skips style layers whose source layer does not exist.
mourner
approved these changes
Oct 14, 2016
jfirebaugh
added a commit
that referenced
this pull request
Oct 14, 2016
* WorkerTile#parse skips layers without a corresponding source layer * WorkerTile#parse warns once when encountering a v1 vector tile layer Covering the issues fixed in #3369 While here, rewrite the existing tests to conform more closely with our test guidelines. (Though technically they still mock domain objects.)
Merged
jfirebaugh
added a commit
that referenced
this pull request
Oct 14, 2016
* WorkerTile#parse skips layers without a corresponding source layer * WorkerTile#parse warns once when encountering a v1 vector tile layer Covering the issues fixed in #3369 While here, rewrite the existing tests to conform more closely with our test guidelines. (Though technically they still mock domain objects.)
jfirebaugh
added a commit
that referenced
this pull request
Oct 14, 2016
* WorkerTile#parse skips layers without a corresponding source layer * WorkerTile#parse warns once when encountering a v1 vector tile layer Covering the issues fixed in #3369 While here, rewrite the existing tests to conform more closely with our test guidelines. (Though technically they still mock domain objects.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
layervariable was being used for both style layers and source layers. As a result, the fact that theversion === 1conditional was being checked at the wrong point went unnoticed.The
if (layer)conditional was also misplaced, but fortunately it didn't matter because the prior loop already skips style layers whose source layer does not exist.Launch Checklist