Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit identity zoom functions #4198

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Conversation

jfirebaugh
Copy link
Contributor

Our function taxonomy benefits from being pared down where possible. Identity zoom functions don't seem useful, and are not implemented in native.

Fixes #4151.

@jfirebaugh jfirebaugh changed the base branch from function-piecewise-noninteger to master February 3, 2017 17:59
Our function taxonomy benefits from being pared down where possible. Identity zoom functions don't seem useful, and are not implemented in native.
@jfirebaugh jfirebaugh merged commit f1ec12d into master Feb 3, 2017
@jfirebaugh jfirebaugh deleted the function-no-identity-zoom branch February 3, 2017 18:00
@jplante
Copy link

jplante commented Jul 5, 2017

This is a feature we would like. We think it's useful.

For example - ALA Leaflet's Circle and CircleMarker - where the radius is based on either distance or pixels - we could use this for setting different radius for a Circle based on data identity attributes

@jfirebaugh
Copy link
Contributor Author

different radius for a Circle based on data identity attributes

That sounds like a regular property-based identity function (which is supported), not an identity zoom function. An identity zoom function would be a function whose output is always the map's current zoom level. (If that's really what you want, you can create an exponential zoom function with base 1 and stops [[0, 0], [maxZoom, maxZoom]], where maxZoom is some arbitrary value >= the maximum zoom your map allows.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants