Multiple Maps cause SQLLite cache(22): SIGBART error #1102

jonathanduty · 2015-03-25T19:49:16Z

Setup:
I modified the left and right navbar buttons to either push a new MBXViewController or pop it using the UINavigationController. I wanted to test navigating from one map to another using push/pop UINavigation controller.

Bug One:
Open the App. Let the map fully load. Then push right nav button and navigate to next map. Start dragging quickly. You will eventually get a SQLLite cache(22): SIGBART error.

SQLite Cache (28)#0 0x0333269a in __pthread_kill ()
#1  0x03360f19 in pthread_kill ()
#2  0x030d9a5a in abort ()
#3  0x0336f527 in abort_message ()
#4  0x03392631 in default_terminate_handler() ()
#5  0x02c30d58 in _objc_terminate() ()
#6  0x0338fcf0 in std::__terminate(void (*)()) ()
#7  0x0338f70f in __cxa_throw ()
#8  0x003bcefb in mapbox::sqlite::Statement::run() at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/platform/default/sqlite3.cpp:146
#9  0x003b0c9b in mbgl::SQLiteCache::process(mbgl::SQLiteCache::RefreshAction&) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/platform/default/sqlite_cache.cpp:262
#10 0x003ba91b in void mbgl::SQLiteCache::ActionDispatcher::operator()<mbgl::SQLiteCache::RefreshAction>(mbgl::SQLiteCache::RefreshAction&) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/platform/default/sqlite_cache.cpp:88
#11 0x003ba896 in mapbox::util::detail::dispatcher<mbgl::SQLiteCache::ActionDispatcher, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>, void, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>::apply(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&, mbgl::SQLiteCache::ActionDispatcher) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/variant.hpp:277
#12 0x003ba687 in mapbox::util::detail::dispatcher<mbgl::SQLiteCache::ActionDispatcher, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>, void, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>::apply(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&, mbgl::SQLiteCache::ActionDispatcher) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/variant.hpp:281
#13 0x003ba417 in mapbox::util::detail::dispatcher<mbgl::SQLiteCache::ActionDispatcher, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>, void, mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>::apply(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&, mbgl::SQLiteCache::ActionDispatcher) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/variant.hpp:281
#14 0x003ba36e in decltype(detail::dispatcher<mbgl::SQLiteCache::ActionDispatcher, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>, mapbox::util::detail::result_of_unary_visit<mbgl::SQLiteCache::ActionDispatcher, mbgl::SQLiteCache::GetAction, void>::type, mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>::apply(fpfp0)) mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>::visit<mbgl::SQLiteCache::ActionDispatcher, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction> >(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&, mbgl::SQLiteCache::ActionDispatcher) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/variant.hpp:694
#15 0x003b276e in decltype(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>::visit(fp0fp)) mapbox::util::apply_visitor<mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>, mbgl::SQLiteCache::ActionDispatcher>(mbgl::SQLiteCache::ActionDispatcher, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/variant.hpp:760
#16 0x003b2704 in mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0::operator()(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&) const at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/platform/default/sqlite_cache.cpp:95
#17 0x003b25a9 in std::__1::__invoke<mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&>(decltype(std::__1::forward<mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&>(fp)(std::__1::forward<mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&>(fp0))), mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&&&, mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&&&) [inlined] at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__functional_base:413
#18 0x003b2588 in std::__1::__function::__func<mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0, std::__1::allocator<mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>, void (mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&)>::operator()(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/functional:1370
#19 0x003b9f28 in std::__1::function<void (mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&)>::operator()(mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&) const at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/functional:1755
#20 0x003b9d1e in mbgl::util::AsyncQueue<mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction> >::process() at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/async_queue.hpp:81
#21 0x003b98c2 in mbgl::util::AsyncQueue<mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction> >::AsyncQueue(uv_loop_s*, std::__1::function<void (mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&)>)::'lambda'(uv_async_s*, int)::operator()(uv_async_s*, int) const at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/async_queue.hpp:32
#22 0x003b985e in mbgl::util::AsyncQueue<mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction> >::AsyncQueue(uv_loop_s*, std::__1::function<void (mapbox::util::variant<mbgl::SQLiteCache::GetAction, mbgl::SQLiteCache::PutAction, mbgl::SQLiteCache::RefreshAction, mbgl::SQLiteCache::StopAction>&)>)::'lambda'(uv_async_s*, int)::__invoke(uv_async_s*, int) at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/include/mbgl/util/async_queue.hpp:30
#23 0x003bdaef in uv__async_event at /Users/kkaefer/Code/mason/libuv-0.10.28/mason_packages/.build/libuv-0.10.28/src/unix/async.c:80
#24 0x003bdf37 in uv__async_io at /Users/kkaefer/Code/mason/libuv-0.10.28/mason_packages/.build/libuv-0.10.28/src/unix/async.c:156
#25 0x003db5fb in uv__io_poll at /Users/kkaefer/Code/mason/libuv-0.10.28/mason_packages/.build/libuv-0.10.28/src/unix/kqueue.c:233
#26 0x003be6da in uv_run at /Users/kkaefer/Code/mason/libuv-0.10.28/mason_packages/.build/libuv-0.10.28/src/unix/core.c:317
#27 0x003b15e8 in mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_1::operator()() const at /Users/jonathanduty/Development/mapbox/mapbox-gl-native/platform/default/sqlite_cache.cpp:101
#28 0x003b13a5 in std::__1::__thread_proxy<std::__1::tuple<mbgl::SQLiteCache::SQLiteCache(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_1> >(void*, void*) at /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2602
#29 0x0335ee13 in _pthread_body ()
#30 0x0335ed89 in _pthread_start ()
#31 0x0335ce52 in thread_start ()

The text was updated successfully, but these errors were encountered:

bleege · 2015-03-25T19:55:38Z

/cc @kkaefer

bleege · 2015-04-17T21:15:21Z

Are you still seeing this @jonathanduty?

bsudekum · 2015-04-28T16:14:52Z

Can confirm I'm also getting an identical error.

kkaefer · 2015-04-28T16:31:43Z

This shouldn't be happening anymore since 4b66c49. Do you have a recent build, @bsudekum?

However, the root cause still exists: Our Cocoa Map objects still encapsulate everything, so they create a separate FileSource (and FileCache) object for every Map view. Instead, when they use the same database file, they should use the same FileCache object. /cc @incanus

incanus · 2015-04-28T16:35:50Z

New build rolled last night, update yer pods.

bsudekum · 2015-04-28T16:38:34Z

👍 . Updating pod now and checking

bsudekum · 2015-04-28T16:55:11Z

Working fine for me now. @jonathanduty good to close?

kkaefer · 2015-04-28T17:17:15Z

No. The original issue still exists. See my comment above.

robipresotto · 2015-04-29T11:21:42Z

2015-04-29 13:17:47.939 Embark[11491:15975096] [ERROR] Database: database is locked
2015-04-29 13:17:47.996 Embark[11491:15975096] [ERROR] Database: database is locked
2015-04-29 13:17:48.264 Embark[11491:15975096] [ERROR] Database: database is locked
2015-04-29 13:17:48.558 Embark[11491:15975096] [ERROR] Database: database is locked

And crash in:

__mutex_base

    _LIBCPP_INLINE_VISIBILITY
    explicit lock_guard(mutex_type& __m)
        : __m_(__m) {__m_.lock();} <<<<<<< STOP HERE
    _LIBCPP_INLINE_VISIBILITY
    lock_guard(mutex_type& __m, adopt_lock_t)
        : __m_(__m) {}
    _LIBCPP_INLINE_VISIBILITY
    ~lock_guard() {__m_.unlock();}

incanus · 2015-04-29T21:34:16Z

I still see database locking problems as well in https://github.com/incanus/PushTest as of incanus/PushTest@2ae2e25. Investigating along with #1103.

kkaefer · 2015-04-29T21:58:30Z

Does that project create more than one Map view?

incanus · 2015-04-30T15:39:14Z

Yes, though via VC pushes, so only momentarily. However, when you've pushed one onto the nav stack, you can go back to the still-existent first one. I will also build out something which does two maps in the same viewport.

kkaefer · 2015-04-30T15:44:34Z

As indicated above, the issue is:

Our Cocoa Map objects still encapsulate everything, so they create a separate FileSource (and FileCache) object for every Map view. Instead, when they use the same database file, they should use the same FileCache object.

incanus · 2015-04-30T15:49:02Z

Yep, going to go for this since we can't have 2+ map objects writing to the same file safely otherwise.

bleege added the iOS Mapbox Maps SDK for iOS label Mar 25, 2015

bleege added the crash label Mar 25, 2015

incanus added this to the iOS Beta 1 milestone Apr 6, 2015

incanus self-assigned this Apr 29, 2015

incanus mentioned this issue Apr 29, 2015

Multiple Maps EXEC_BAD_ACCESS TransformState::getLatLng() #1103

Closed

incanus added a commit that referenced this issue Apr 30, 2015

fixes #1102: implement reference-counted shared file cache vendor

402f850

incanus mentioned this issue Apr 30, 2015

fixes #1103: allow multiple maps by not using global pointers #1386

Merged

incanus closed this as completed in c69e985 Apr 30, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple Maps cause SQLLite cache(22): SIGBART error #1102

Multiple Maps cause SQLLite cache(22): SIGBART error #1102

jonathanduty commented Mar 25, 2015

bleege commented Mar 25, 2015

bleege commented Apr 17, 2015

bsudekum commented Apr 28, 2015

kkaefer commented Apr 28, 2015

incanus commented Apr 28, 2015 via email

bsudekum commented Apr 28, 2015

bsudekum commented Apr 28, 2015

kkaefer commented Apr 28, 2015

robipresotto commented Apr 29, 2015

incanus commented Apr 29, 2015

kkaefer commented Apr 29, 2015

incanus commented Apr 30, 2015

kkaefer commented Apr 30, 2015

incanus commented Apr 30, 2015

Multiple Maps cause SQLLite cache(22): SIGBART error #1102

Multiple Maps cause SQLLite cache(22): SIGBART error #1102

Comments

jonathanduty commented Mar 25, 2015

bleege commented Mar 25, 2015

bleege commented Apr 17, 2015

bsudekum commented Apr 28, 2015

kkaefer commented Apr 28, 2015

incanus commented Apr 28, 2015 via email

bsudekum commented Apr 28, 2015

bsudekum commented Apr 28, 2015

kkaefer commented Apr 28, 2015

robipresotto commented Apr 29, 2015

incanus commented Apr 29, 2015

kkaefer commented Apr 29, 2015

incanus commented Apr 30, 2015

kkaefer commented Apr 30, 2015

incanus commented Apr 30, 2015