Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Implement Material Design In Test App #1856

Closed
bleege opened this issue Jul 9, 2015 · 21 comments
Closed

Implement Material Design In Test App #1856

bleege opened this issue Jul 9, 2015 · 21 comments
Assignees
Labels
Android Mapbox Maps SDK for Android

Comments

@bleege
Copy link
Contributor

bleege commented Jul 9, 2015

See documentation for more details.

@bleege bleege added this to the Android Beta milestone Jul 9, 2015
@incanus
Copy link
Contributor

incanus commented Jul 9, 2015

Can we break this down any more concretely? Is there a way to do it incrementally?

@incanus incanus added the Android Mapbox Maps SDK for Android label Jul 9, 2015
@bleege
Copy link
Contributor Author

bleege commented Jul 9, 2015

Yep. The main goal here is to make people aware that we're explicitly going to use Material instead of the previous styles now that Google has improved Backward Compatibility via the Android Design Support Library as of Google IO 2015.

Initial Setup

  • Add Android Design Support Library to Gradle via compile 'com.android.support:design:22.2.0'
  • Change "Old" Widgets To "New" Widgets

On Going

  • Use "New Design Widgets" like FAB and Snackbar instead of old ones.

Bigger Picture

@hallahan
Copy link
Contributor

👍 I think this is going to be awesome. I'd also enjoy seeing a little bit of tweaking to give it the Mapbox look and feel.

@ljbade
Copy link
Contributor

ljbade commented Jul 28, 2015

Interesting. Gets hard to keep track of all the UI paradigm changes on Android and the various compatibility libraries.

@bleege
Copy link
Contributor Author

bleege commented Aug 7, 2015

I'm going to start converting the TestGLApp to Material Design based on Chris Banes' Cheesesquare demo project. This will help ensure that the GL SDK, and specifically the MapView work properly in the new design paradigm that Google is promoting as well as what customers will likely expect. It'll also make it easier to add new features for testing to the app by using the Navigation Drawer.

@bleege
Copy link
Contributor Author

bleege commented Aug 7, 2015

For future comparison, here are screenshots of the current UI.

20150807-starting-point-1

20150807-starting-point-2

@erf
Copy link
Contributor

erf commented Aug 7, 2015

May i suggest implementing a transparent statusbar with a floating toolbar for maximum map view. ( like in google maps)

@bleege
Copy link
Contributor Author

bleege commented Aug 7, 2015

Initial conversion to Material Design has been completed. It's been tested on Samsung Galaxy S5 running Android 21. All that remains is to refactor the Compass UI from the SDK into the TestApp. The functionality should stay in the SDK as is, but the FAB should be separated because the SDK should not force a design implementation on developers (outside the existing user dot and compass).

20150807-main-screen

20150807-navdrawer

@bleege
Copy link
Contributor Author

bleege commented Aug 10, 2015

Next up is to remove the FAB designed User Location Modes (None, Location, Follow) from the TestApp and place it in the SDK via an API. The Google Maps Android API is a bit unclear about this, so I'm thinking that we mirror the Mapbox Android Raster SDK's TrackingMode API.

bleege added a commit that referenced this issue Aug 10, 2015
… API. Making Compass visible under Toolbar.
@bleege
Copy link
Contributor Author

bleege commented Aug 10, 2015

Initial refactor to remove FAB UI for location from SDK and replace it with an API. Part of this meant returning the Compass image, which was hidden under the Toolbar in Material Design setup. Thinking this has to do with FrameLayout nature of MapView. Will likely have to redo once follow modes UI is settled. Screenshots below of before and after.

20150810-compass-under-toolbar
Lollipop Before

20150810-compass-out-from-under-toolbar
Lollipop After

screen shot 2015-08-10 at 3 56 32 pm
KitKat After

@bleege
Copy link
Contributor Author

bleege commented Aug 12, 2015

Ticketed out the more responsive User Location Mode work in #2049. Thanks again to @erf for the great head start by building this.

The FAB Shadow has also been merged as of #2047 so all remaining issues for this ticket should be complete now.

@bleege bleege closed this as completed Aug 12, 2015
bleege added a commit that referenced this issue Aug 12, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
…g mode API. Making Compass visible under Toolbar.
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

No branches or pull requests

6 participants