Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Asynchronous TextureView #10334

Merged
merged 5 commits into from
Nov 2, 2017
Merged

Asynchronous TextureView #10334

merged 5 commits into from
Nov 2, 2017

Conversation

ivovandongen
Copy link
Contributor

@ivovandongen ivovandongen commented Oct 31, 2017

Brings back the (deprecated) TextureView option, removed in #9576. Built on top of the a-synchronous rendering with a dedicated render thread to unblock the main thread as much as possible.

TODO:

  • Cleanup code
  • Cleanup on exit
  • Handle lost context
  • Handle bad surface
  • Life-cycle handling:
    • pause/resume
    • destroy
    • multi-window
    • rotate
  • Test activities
    • Debug
    • Transform
    • Resize
  • un-deprecate

@ivovandongen ivovandongen added the Android Mapbox Maps SDK for Android label Oct 31, 2017
@ivovandongen ivovandongen self-assigned this Oct 31, 2017
@ivovandongen
Copy link
Contributor Author

@tobrun @zugaldia Do we still want to mark this as deprecated now that we're bringing it back?

@zugaldia
Copy link
Member

Do we still want to mark this as deprecated now that we're bringing it back?

Capturing chat, moving forward:

  • We're gonna remove the deprecated tag from TextureView mode and commit to maintaining this mode.
  • We're gonna update the current docs to reflect that regular asynchronous rendering (non-TextureView) is still the recommended mode to render the map as it's more performant. Additionally, we'd like to include common scenarios where TextureView could be a good fallback option.

@ivovandongen ivovandongen force-pushed the ivd-texture-view branch 4 times, most recently from 9cad532 to 8edbf18 Compare November 1, 2017 13:03
@ivovandongen
Copy link
Contributor Author

@tobrun Tested this on the devices I have (Pixel and Galaxy Nexus). Needs a more thorough review/test, but otherwise good to go.

@ivovandongen ivovandongen force-pushed the ivd-texture-view branch 2 times, most recently from fed4acb to b974b9b Compare November 1, 2017 14:45
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, the new abstraction is really clean. Tested on 3 devices without an issue. Will be running additional tests later when cherry-picked to the release branch.

@zugaldia
Copy link
Member

zugaldia commented Nov 1, 2017

🎉

I still see a couple of "deprecated" messages in the comments, could we remove those before merging?

@ivovandongen
Copy link
Contributor Author

I still see a couple of "deprecated" messages in the comments, could we remove those before merging?

Sorry, think I got them all now @zugaldia

@ivovandongen ivovandongen merged commit 1970a94 into master Nov 2, 2017
@ivovandongen ivovandongen deleted the ivd-texture-view branch November 2, 2017 17:55
@tobrun tobrun mentioned this pull request Nov 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants