This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Reverting vectorDrawables.useSupportLibrary to false #13144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to increase stability on Android 4.4 and below
|
Thank you for this contribution, will let @LukasPaczos review |
|
Was able to get my hands on a kitkat test device and was able to reproduce and validate that this fixes the issue. Thank you for the contribution @DonTomika. |
tobrun
approved these changes
Oct 23, 2018
|
Thank you for following up @DonTomika , it seems we have a CI issue for running external PRs, fix for that in #13167. To not further block this PR, I'm cherrypicking your commit and will follow up on that PR myself. Thanks again for your contribution! |
|
following up on this PR in #13168 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solve vector drawable related crashes on Android 4.x. Some drawables had to be changed because color references in vector drawables are not supported when vectorDrawables.useSupportLibrary is turned off. See #13099 for details.