Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] telemetry - horizontal accuracy #7237

Merged
merged 1 commit into from
Dec 2, 2016
Merged

Conversation

ivovandongen
Copy link
Contributor

@ivovandongen ivovandongen commented Nov 30, 2016

Fixes #7235

Review @tobrun

@ivovandongen ivovandongen added the Android Mapbox Maps SDK for Android label Nov 30, 2016
@ivovandongen ivovandongen self-assigned this Nov 30, 2016
@mention-bot
Copy link

@ivovandongen, thanks for your PR! By analyzing this pull request, we identified @zugaldia to be potential reviewers.

@ivovandongen
Copy link
Contributor Author

@aaronlidman @l-r Should be sufficient right? I haven't put in any rounding for now.

@ivovandongen ivovandongen mentioned this pull request Nov 30, 2016
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@l-r
Copy link

l-r commented Nov 30, 2016

Cool @ivovandongen. Are we going to have some logic to filter out certain values as per that are null on each platform? I'm on the fence for this one.

@ivovandongen
Copy link
Contributor Author

ivovandongen commented Nov 30, 2016

Are we going to have some logic to filter out certain values as per that are null on each platform? I'm on the fence for this one.

Up to you. We can add a 0 check if you don't want those location updates.

@aaronlidman
Copy link

Yeah

If this location does not have an accuracy, then 0.0 is returned

Can we only include > 0 for Android?

@l-r
Copy link

l-r commented Nov 30, 2016

If we can add rounding in there I think this is good to go.

@aaronlidman
Copy link

Can we only include > 0 for Android?

Ignore my previous, I've been convinced otherwise.

Sounds like rounding is the only hold up.

@ivovandongen
Copy link
Contributor Author

If we can add rounding in there I think this is good to go.

event.put(MapboxEvent.KEY_HORIZONTAL_ACCURACY, Math.round(location.getAccuracy()));

@ivovandongen ivovandongen merged commit d904ba6 into master Dec 2, 2016
@ivovandongen ivovandongen deleted the 7235-android-ha branch December 2, 2016 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants