-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[android] telemetry - horizontal accuracy #7237
Conversation
@ivovandongen, thanks for your PR! By analyzing this pull request, we identified @zugaldia to be potential reviewers. |
@aaronlidman @l-r Should be sufficient right? I haven't put in any rounding for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Cool @ivovandongen. Are we going to have some logic to filter out certain values as per that are null on each platform? I'm on the fence for this one. |
Up to you. We can add a 0 check if you don't want those location updates. |
Yeah
Can we only include > 0 for Android? |
If we can add rounding in there I think this is good to go. |
Ignore my previous, I've been convinced otherwise. Sounds like rounding is the only hold up. |
8b34b91
to
eeb2b16
Compare
eeb2b16
to
fa96c42
Compare
Line 356 in fa96c42
|
Fixes #7235
Review @tobrun