This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
move calculation of LatLngBounds to core #8765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
changed the title
tobrun
force-pushed
the
tvn-test-latlngbounds-core
branch
3 times, most recently
from
e970512
to
4883614
Compare
ivovandongen
suggested changes
Apr 20, 2017
| @@ -449,6 +450,10 @@ void NativeMapView::setLatLng(jni::JNIEnv&, jni::jdouble latitude, jni::jdouble | |||
| map->setLatLng(mbgl::LatLng(latitude, longitude), insets, mbgl::AnimationOptions{mbgl::Milliseconds(duration)}); | |||
| } | |||
|
|
|||
| jni::Object<CameraPosition> NativeMapView::getCameraForLatLngBounds(jni::JNIEnv& env, jni::Object<LatLngBounds> jBounds) {\ | |||
There was a problem hiding this comment.
Does this compile with the trailing slash?
tobrun
force-pushed
the
tvn-test-latlngbounds-core
branch
from
4883614
to
a53022b
Compare
ivovandongen
approved these changes
Apr 20, 2017
This was referenced May 18, 2017
This was referenced Jun 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4796
This PR moves calculating LatLngBounds to core instead of doing it in java. To achieve this I had to expose a
public CameraPosition getCameraForLatLngbounds(LatLngBounds bounds)on MapboxMap (afaik the only way to make it work with our currentCameraUpdateFactorysetup).This PR also refactors returning a CameraPosition directly from core instead of an double array. (this refactors the code for
getCameraValuesintogetCameraPosition.TODO:
NativeMapView#getCameraValues), it would be cleaner to return an actual CameraPosition object (this refactor needs to happpen for both getCameraForLatLngBounds as for getCameraPosition).