Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] allow filesource url transform reset #8957

Merged
merged 1 commit into from
May 12, 2017
Merged

[core] allow filesource url transform reset #8957

merged 1 commit into from
May 12, 2017
+10 −6

Conversation

ivovandongen
Copy link
Contributor

Fixes #8955 by allowing a nullptr to reset the transform callback

@ivovandongen ivovandongen added Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl crash labels May 11, 2017
@ivovandongen ivovandongen self-assigned this May 11, 2017
@ivovandongen ivovandongen requested a review from kkaefer May 11, 2017 10:12
@tobrun tobrun added this to the android-v5.1.0 milestone May 12, 2017
kkaefer
kkaefer approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@kkaefer kkaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ivovandongen ivovandongen merged commit 6b0e0a9 into master May 12, 2017
@ivovandongen ivovandongen deleted the filesource-allow-transform-reset branch May 12, 2017 11:55
This was referenced May 18, 2017
Closed
Closed
@tobrun tobrun mentioned this pull request Jun 9, 2017
Closed
12 tasks
@tobrun tobrun mentioned this pull request Jun 21, 2017
Closed
11 tasks
@tobrun tobrun mentioned this pull request Jun 30, 2017
Closed
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kkaefer kkaefer kkaefer approved these changes

Assignees

@ivovandongen ivovandongen

Labels
Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl crash
Projects
None yet
Milestone
android-v5.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ivovandongen @kkaefer @tobrun