This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make actor self reference optional - again #9724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses a different method of constructor selection that also works on Apple clang < 8.2.
|
@tmpsantos Re-enabling this as I need it for #9576 (using the renderer as an Actor). Apparently using: instead of works on older apple clang versions. Tested with Xcode 8.2 ( |
tmpsantos
approved these changes
Aug 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9591 we added a way to construct Actors from arbitrary objects (without requiring modifying the constructor(s)). This broke on Apple clang < 8.2 which is needed for Qt and got reversed in #9720.
This PR re-introduces the same construct with a slightly different syntax on the templates which works with older apple clang versions as well.