Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Transparent background on iOS #579

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix Transparent background on iOS #579

wants to merge 5 commits into from

Conversation

tranhuongk
Copy link

@tranhuongk tranhuongk commented Jun 12, 2024 •
edited
Loading

Fix #415

What is the motivation and context behind this change?

set mapView.isOpaque = false

Pull request checklist:

  • Add a changelog entry.
  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.

@tranhuongk tranhuongk requested review from a team as code owners June 12, 2024 03:50
@tranhuongk tranhuongk requested a review from OdNairy June 12, 2024 03:50
evil159
evil159 requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@evil159 evil159 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tranhuongk, thank you for your contribution! Could you make this behavior configurable from the dart side, plus this option is also applicable for Android, there opacity can be achieved by using a texture view rendering - MapInitOptions.textureView.

@tranhuongk
Copy link
Author

@evil159 with textureView

Flag indicating to use a TextureView as render surface for the MapWidget. Only works for Android

@OdNairy OdNairy removed their request for review July 1, 2024 07:12
@tranhuongk tranhuongk requested a review from evil159 July 2, 2024 07:18
@tranhuongk
Copy link
Author

@evil159 @OdNairy Can we get back to this issue?

@tranhuongk
Copy link
Author

@evil159

@evil159 evil159 removed the request for review from a team October 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evil159 evil159 Awaiting requested review from evil159

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transparent background for the map
2 participants
@tranhuongk @evil159