Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XCParty] Add tag name if HEAD has any #1424

Merged
merged 3 commits into from
Jul 4, 2022
Merged

[XCParty] Add tag name if HEAD has any #1424

merged 3 commits into from
Jul 4, 2022

Conversation

OdNairy
Copy link
Contributor

@OdNairy OdNairy commented Jul 4, 2022 •
edited
Loading

  1. Adds build.tag_name if there is the tag on the HEAD repo commit
  2. Refactor to utilize Process in shell function return

Pull request checklist:

  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Add any new public, top-level symbols to the Jazzy config's custom_categories (scripts/doc-generation/.jazzy.yaml)
  • Describe the changes in this PR, especially public API changes.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • Review and agree to the Contributor License Agreement (CLA).
    MAPSIOS-39

@OdNairy OdNairy requested a review from a team as a code owner July 4, 2022 12:37
@OdNairy OdNairy merged commit 427f83d into main Jul 4, 2022
@OdNairy OdNairy deleted the feature/tag_metrics branch July 4, 2022 15:27
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy
[XCParty] Add tag name if HEAD has any (#1424)
8193ba1
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy
[XCParty] Add tag name if HEAD has any (#1424)
304c7df
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy @ZiZasaurus
@evil159 @tobrun
Cherry pick main changes to release/10.7 (#1462)
375c309 
* Update changelog (#1418)

* Add style toggle to location example (#1413)

* [XCParty] Add tag name if HEAD has any (#1424)

* [XCParty] Export crash reports for XCResult (#1434)

* Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431)

* Add cast shadow option to 3d puck config (#1435)

* Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440)

* Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429)

* Add option to support measurements from the only last run (#1445)

* Update examples (#1443)

* Fix flaky test (#1450)

* Fix view annotation losing its feature association after update (#1446)

* Enable `modelCastsShadow` option for custom location puck config (#1447)

* enabled model casts shadows option for custom location puck configuration

* Provide default value for list of last-run metrics (#1453)

* Update CoreMaps to `10.7.0-rc.1` (#1456)

* Update CoreMaps to 10.7.0-rc.1

* Update changelog

* Update changelog header (#1459)

* Update 10.7.0 versions (#1460)

Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy @ZiZasaurus
@evil159 @tobrun
Cherry pick main changes to release/10.7 (#1463)
da8254b 
* Add style toggle to location example (#1413)

* [XCParty] Add tag name if HEAD has any (#1424)

* [XCParty] Export crash reports for XCResult (#1434)

* Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431)

* Add cast shadow option to 3d puck config (#1435)

* Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440)

* Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429)

* Add option to support measurements from the only last run (#1445)

* Update examples (#1443)

* Fix flaky test (#1450)

* Fix view annotation losing its feature association after update (#1446)

* Enable `modelCastsShadow` option for custom location puck config (#1447)

* enabled model casts shadows option for custom location puck configuration

* Provide default value for list of last-run metrics (#1453)

* Update CoreMaps to `10.7.0-rc.1` (#1456)

* Update CoreMaps to 10.7.0-rc.1

* Update changelog

* Update changelog header (#1459)

* Update 10.7.0 versions (#1460)

Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy pushed a commit that referenced this pull request Apr 6, 2023
@evil159
Pass metal view size instead of map view size as they can diverge to …
b128233 
…MapboxMap (#1424)
mapbox-github-ci-writer-public-1 bot pushed a commit that referenced this pull request Apr 13, 2023
@evil159
Pass metal view size instead of map view size as they can diverge to …
d627aba 
…MapboxMap (#1424)
OdNairy pushed a commit that referenced this pull request Aug 22, 2023
@evil159
Pass metal view size instead of map view size as they can diverge to …
188afc5 
…MapboxMap (#1424)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evil159 evil159 evil159 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OdNairy @evil159