Mark camera functions as unsupported for globe projection #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… results in a no-op
tobrun
added
the
skip changelog
evil159
reviewed
Jul 11, 2022
| @@ -314,6 +314,8 @@ public final class MapboxMap: MapboxMapProtocol { | |||
|
|
|||
| /// Calculates a `CameraOptions` to fit a `CoordinateBounds` | |||
| /// | |||
| /// This API isn't supported by Globe projection. | |||
| /// | |||
There was a problem hiding this comment.
Would it make sense to also log a warning message to the console when this(and others) method is called and projection is globe? To increase chances this message is seen - sometimes docs are not read that carefully(or at all).
Something like this:
if style.projection.name == .globe {
Log.warning(forMessage: "Camera API isn't supported by Globe projection", category: "Camera")
}There was a problem hiding this comment.
This is done upstream already :)
evil159
approved these changes
Jul 11, 2022
OdNairy
added a commit
that referenced
this pull request
Jul 14, 2022
* Update changelog (#1418) * Add style toggle to location example (#1413) * [XCParty] Add tag name if HEAD has any (#1424) * [XCParty] Export crash reports for XCResult (#1434) * Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431) * Add cast shadow option to 3d puck config (#1435) * Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440) * Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429) * Add option to support measurements from the only last run (#1445) * Update examples (#1443) * Fix flaky test (#1450) * Fix view annotation losing its feature association after update (#1446) * Enable `modelCastsShadow` option for custom location puck config (#1447) * enabled model casts shadows option for custom location puck configuration * Provide default value for list of last-run metrics (#1453) * Update CoreMaps to `10.7.0-rc.1` (#1456) * Update CoreMaps to 10.7.0-rc.1 * Update changelog * Update changelog header (#1459) * Update 10.7.0 versions (#1460) Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy
added a commit
that referenced
this pull request
Jul 14, 2022
* Add style toggle to location example (#1413) * [XCParty] Add tag name if HEAD has any (#1424) * [XCParty] Export crash reports for XCResult (#1434) * Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431) * Add cast shadow option to 3d puck config (#1435) * Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440) * Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429) * Add option to support measurements from the only last run (#1445) * Update examples (#1443) * Fix flaky test (#1450) * Fix view annotation losing its feature association after update (#1446) * Enable `modelCastsShadow` option for custom location puck config (#1447) * enabled model casts shadows option for custom location puck configuration * Provide default value for list of last-run metrics (#1453) * Update CoreMaps to `10.7.0-rc.1` (#1456) * Update CoreMaps to 10.7.0-rc.1 * Update changelog * Update changelog header (#1459) * Update 10.7.0 versions (#1460) Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
maios
added a commit
that referenced
this pull request
Mar 24, 2023
maios
added a commit
that referenced
this pull request
Mar 24, 2023
* Add missing changelog entries (#1440) --------- Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com> Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
evil159
pushed a commit
that referenced
this pull request
Mar 31, 2023
OdNairy
pushed a commit
that referenced
this pull request
Apr 5, 2023
OdNairy
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark camera functions as unsupported for globe projection,
Invocation results in a no-op.
Pull request checklist:
custom_categories(scripts/doc-generation/.jazzy.yaml)## mainheading near the top).