-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style toggle to location example #1413
Conversation
…when style changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, address the comments.
I also would like to ask you to attach a screenshot to the PR.
Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more comments.
The same applies to TrackingModeExample.swift
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Update changelog (#1418) * Add style toggle to location example (#1413) * [XCParty] Add tag name if HEAD has any (#1424) * [XCParty] Export crash reports for XCResult (#1434) * Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431) * Add cast shadow option to 3d puck config (#1435) * Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440) * Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429) * Add option to support measurements from the only last run (#1445) * Update examples (#1443) * Fix flaky test (#1450) * Fix view annotation losing its feature association after update (#1446) * Enable `modelCastsShadow` option for custom location puck config (#1447) * enabled model casts shadows option for custom location puck configuration * Provide default value for list of last-run metrics (#1453) * Update CoreMaps to `10.7.0-rc.1` (#1456) * Update CoreMaps to 10.7.0-rc.1 * Update changelog * Update changelog header (#1459) * Update 10.7.0 versions (#1460) Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
* Add style toggle to location example (#1413) * [XCParty] Add tag name if HEAD has any (#1424) * [XCParty] Export crash reports for XCResult (#1434) * Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431) * Add cast shadow option to 3d puck config (#1435) * Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440) * Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429) * Add option to support measurements from the only last run (#1445) * Update examples (#1443) * Fix flaky test (#1450) * Fix view annotation losing its feature association after update (#1446) * Enable `modelCastsShadow` option for custom location puck config (#1447) * enabled model casts shadows option for custom location puck configuration * Provide default value for list of last-run metrics (#1453) * Update CoreMaps to `10.7.0-rc.1` (#1456) * Update CoreMaps to 10.7.0-rc.1 * Update changelog * Update changelog header (#1459) * Update 10.7.0 versions (#1460) Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
Adding style toggle to verify location puck is redrawn when style changes.
Pull request checklist:
custom_categories
(scripts/doc-generation/.jazzy.yaml)## main
heading near the top).