Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style toggle to location example #1413

Merged
merged 11 commits into from
Jul 4, 2022
Merged

Add style toggle to location example #1413

merged 11 commits into from
Jul 4, 2022

Conversation

ZiZasaurus
Copy link
Contributor

@ZiZasaurus ZiZasaurus commented Jun 29, 2022 •
edited
Loading

Adding style toggle to verify location puck is redrawn when style changes.

Pull request checklist:

  • Write tests for all new functionality. If tests were not written, please explain why.
  • Add documentation comments for any added or updated public APIs.
  • Add any new public, top-level symbols to the Jazzy config's custom_categories (scripts/doc-generation/.jazzy.yaml)
  • Describe the changes in this PR, especially public API changes.
  • Add a changelog entry to to bottom of the relevant section (typically the ## main heading near the top).
  • Update the guides (internal access only), README.md, and DEVELOPING.md if their contents are impacted by these changes.
  • Review and agree to the Contributor License Agreement (CLA).

@ZiZasaurus ZiZasaurus requested a review from a team as a code owner June 29, 2022 09:06
@ZiZasaurus ZiZasaurus requested a review from OdNairy June 29, 2022 09:07
@ZiZasaurus ZiZasaurus enabled auto-merge (squash) June 29, 2022 09:27
OdNairy
OdNairy reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@OdNairy OdNairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, address the comments.
I also would like to ask you to attach a screenshot to the PR.

Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/TrackingModeExample.swift Outdated Show resolved Hide resolved
ZiZasaurus and others added 3 commits June 29, 2022 11:26
@ZiZasaurus @OdNairy
Update Apps/Examples/Examples/All Examples/SwitchStylesExample.swift
3df298d 
Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
@ZiZasaurus @OdNairy
Update Apps/Examples/Examples/All Examples/SwitchStylesExample.swift
f5cad6a 
Co-authored-by: Roman Gardukevich <roman.gardukevich@mapbox.com>
@ZiZasaurus
made requested changes
2a18b3b
@ZiZasaurus ZiZasaurus requested a review from OdNairy June 29, 2022 16:20
@ZiZasaurus ZiZasaurus requested a review from OdNairy June 29, 2022 20:06
@ZiZasaurus ZiZasaurus requested a review from OdNairy June 30, 2022 14:47
@ZiZasaurus ZiZasaurus requested a review from OdNairy June 30, 2022 16:31
OdNairy
OdNairy reviewed Jul 1, 2022
View reviewed changes
Copy link
Contributor

@OdNairy OdNairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments.
The same applies to TrackingModeExample.swift.

Apps/Examples/Examples/All Examples/SwitchStylesExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/SwitchStylesExample.swift Outdated Show resolved Hide resolved
Apps/Examples/Examples/All Examples/SwitchStylesExample.swift Show resolved Hide resolved
Apps/Examples/Examples/All Examples/SwitchStylesExample.swift Show resolved Hide resolved
Apps/Examples/Examples/All Examples/SwitchStylesExample.swift Show resolved Hide resolved
@ZiZasaurus ZiZasaurus requested a review from OdNairy July 1, 2022 15:49
OdNairy
OdNairy approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@OdNairy OdNairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZiZasaurus ZiZasaurus merged commit d5a4c2d into main Jul 4, 2022
@ZiZasaurus ZiZasaurus deleted the zjm-AddStyleToggle branch July 4, 2022 13:32
OdNairy pushed a commit that referenced this pull request Jul 14, 2022
@ZiZasaurus @OdNairy
Add style toggle to location example (#1413)
92446d4
OdNairy pushed a commit that referenced this pull request Jul 14, 2022
@ZiZasaurus @OdNairy
Add style toggle to location example (#1413)
f8680b2
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy @ZiZasaurus
@evil159 @tobrun
Cherry pick main changes to release/10.7 (#1462)
375c309 
* Update changelog (#1418)

* Add style toggle to location example (#1413)

* [XCParty] Add tag name if HEAD has any (#1424)

* [XCParty] Export crash reports for XCResult (#1434)

* Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431)

* Add cast shadow option to 3d puck config (#1435)

* Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440)

* Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429)

* Add option to support measurements from the only last run (#1445)

* Update examples (#1443)

* Fix flaky test (#1450)

* Fix view annotation losing its feature association after update (#1446)

* Enable `modelCastsShadow` option for custom location puck config (#1447)

* enabled model casts shadows option for custom location puck configuration

* Provide default value for list of last-run metrics (#1453)

* Update CoreMaps to `10.7.0-rc.1` (#1456)

* Update CoreMaps to 10.7.0-rc.1

* Update changelog

* Update changelog header (#1459)

* Update 10.7.0 versions (#1460)

Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy @ZiZasaurus
@evil159 @tobrun
Cherry pick main changes to release/10.7 (#1463)
da8254b 
* Add style toggle to location example (#1413)

* [XCParty] Add tag name if HEAD has any (#1424)

* [XCParty] Export crash reports for XCResult (#1434)

* Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431)

* Add cast shadow option to 3d puck config (#1435)

* Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440)

* Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429)

* Add option to support measurements from the only last run (#1445)

* Update examples (#1443)

* Fix flaky test (#1450)

* Fix view annotation losing its feature association after update (#1446)

* Enable `modelCastsShadow` option for custom location puck config (#1447)

* enabled model casts shadows option for custom location puck configuration

* Provide default value for list of last-run metrics (#1453)

* Update CoreMaps to `10.7.0-rc.1` (#1456)

* Update CoreMaps to 10.7.0-rc.1

* Update changelog

* Update changelog header (#1459)

* Update 10.7.0 versions (#1460)

Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy added a commit that referenced this pull request Aug 22, 2023
@OdNairy
Bump Xcode image for integration tests (#1413)
23a492c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OdNairy OdNairy OdNairy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZiZasaurus @OdNairy