Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #1443

Merged
merged 7 commits into from
Jul 13, 2022
Merged

Update examples #1443

merged 7 commits into from
Jul 13, 2022

Conversation

evil159
Copy link
Contributor

@evil159 evil159 commented Jul 12, 2022

This PR:

  • Updates tracking mode example to fix auto layout constraints conflict and make initial loading time faster
  • Updates debug map example for the map to fill all visible space
  • Updates the root view controller to use search controller instead of standalone search bar
  • Removes info button from every example since the same text is displayed in the table view
Before After
Simulator Screen Shot - iPhone 13 - 2022-07-12 at 13 44 49 Simulator Screen Shot - iPhone 13 - 2022-07-12 at 13 39 18
Simulator Screen Shot - iPhone 13 - 2022-07-12 at 13 44 36 Simulator Screen Shot - iPhone 13 - 2022-07-12 at 13 40 13
Simulator Screen Shot - iPhone 13 - 2022-07-12 at 13 44 32 Simulator Screen Shot - iPhone 13 - 2022-07-12 at 13 43 44

Pull request checklist:

  • Describe the changes in this PR, especially public API changes.
  • Review and agree to the Contributor License Agreement (CLA).

@evil159 evil159 requested a review from a team as a code owner July 12, 2022 10:49
@OdNairy OdNairy requested a review from ZiZasaurus July 12, 2022 10:56
@evil159 @maios
Apply suggestions from code review
99539b2 
Co-authored-by: Mai Mai <mai.mai@mapbox.com>
@evil159 evil159 merged commit 4c5fafe into main Jul 13, 2022
@evil159 evil159 deleted the rl/update_examples branch July 13, 2022 08:31
OdNairy pushed a commit that referenced this pull request Jul 14, 2022
@evil159 @OdNairy
Update examples (#1443)
1e64b09
OdNairy pushed a commit that referenced this pull request Jul 14, 2022
@evil159 @OdNairy
Update examples (#1443)
6eaa581
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy @ZiZasaurus
@evil159 @tobrun
Cherry pick main changes to release/10.7 (#1462)
375c309 
* Update changelog (#1418)

* Add style toggle to location example (#1413)

* [XCParty] Add tag name if HEAD has any (#1424)

* [XCParty] Export crash reports for XCResult (#1434)

* Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431)

* Add cast shadow option to 3d puck config (#1435)

* Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440)

* Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429)

* Add option to support measurements from the only last run (#1445)

* Update examples (#1443)

* Fix flaky test (#1450)

* Fix view annotation losing its feature association after update (#1446)

* Enable `modelCastsShadow` option for custom location puck config (#1447)

* enabled model casts shadows option for custom location puck configuration

* Provide default value for list of last-run metrics (#1453)

* Update CoreMaps to `10.7.0-rc.1` (#1456)

* Update CoreMaps to 10.7.0-rc.1

* Update changelog

* Update changelog header (#1459)

* Update 10.7.0 versions (#1460)

Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy added a commit that referenced this pull request Jul 14, 2022
@OdNairy @ZiZasaurus
@evil159 @tobrun
Cherry pick main changes to release/10.7 (#1463)
da8254b 
* Add style toggle to location example (#1413)

* [XCParty] Add tag name if HEAD has any (#1424)

* [XCParty] Export crash reports for XCResult (#1434)

* Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431)

* Add cast shadow option to 3d puck config (#1435)

* Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440)

* Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429)

* Add option to support measurements from the only last run (#1445)

* Update examples (#1443)

* Fix flaky test (#1450)

* Fix view annotation losing its feature association after update (#1446)

* Enable `modelCastsShadow` option for custom location puck config (#1447)

* enabled model casts shadows option for custom location puck configuration

* Provide default value for list of last-run metrics (#1453)

* Update CoreMaps to `10.7.0-rc.1` (#1456)

* Update CoreMaps to 10.7.0-rc.1

* Update changelog

* Update changelog header (#1459)

* Update 10.7.0 versions (#1460)

Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com>
Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy added a commit that referenced this pull request Apr 6, 2023
@OdNairy @persidskiy
Generate private code only when necessary (#1443)
93992d2 
* Generate private files only if the content is different to public spec

* Update private code generation

* Improve Makefile, add few new commands

* Refactor style-code generator

* Remove deprecated textLineHeight from template

* Keep swiftlint files in generated folders

* Make regenerate-code a default rule

* Update generate-annotations.list

* Generate styles for both private and public in single run (#1452)

---------

Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com>
mapbox-github-ci-writer-public-1 bot pushed a commit that referenced this pull request Apr 13, 2023
@OdNairy @persidskiy
Generate private code only when necessary (#1443)
821adb4 
* Generate private files only if the content is different to public spec

* Update private code generation

* Improve Makefile, add few new commands

* Refactor style-code generator

* Remove deprecated textLineHeight from template

* Keep swiftlint files in generated folders

* Make regenerate-code a default rule

* Update generate-annotations.list

* Generate styles for both private and public in single run (#1452)

---------

Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com>
OdNairy added a commit that referenced this pull request Aug 22, 2023
@OdNairy @persidskiy
Generate private code only when necessary (#1443)
9185780 
* Generate private files only if the content is different to public spec

* Update private code generation

* Improve Makefile, add few new commands

* Refactor style-code generator

* Remove deprecated textLineHeight from template

* Keep swiftlint files in generated folders

* Make regenerate-code a default rule

* Update generate-annotations.list

* Generate styles for both private and public in single run (#1452)

---------

Co-authored-by: Ivan Persidsky <ivan.persidskii@mapbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OdNairy OdNairy OdNairy approved these changes

@maios maios maios approved these changes

@ZiZasaurus ZiZasaurus Awaiting requested review from ZiZasaurus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evil159 @OdNairy @maios