-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a way to initialise TilesetDescriptorOptionsForTilesets #1431
Merged
evil159
merged 2 commits into
main
from
rl/MAPSIOS-222/init_TilesetDescriptorOptionsForTilesets
Jul 7, 2022
Merged
Expose a way to initialise TilesetDescriptorOptionsForTilesets #1431
evil159
merged 2 commits into
main
from
rl/MAPSIOS-222/init_TilesetDescriptorOptionsForTilesets
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OdNairy
approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sources/MapboxMaps/Offline/TilesetDescriptorOptionsForTilesets+MapboxMaps.swift
Show resolved
Hide resolved
evil159
deleted the
rl/MAPSIOS-222/init_TilesetDescriptorOptionsForTilesets
branch
July 7, 2022 10:01
OdNairy
pushed a commit
that referenced
this pull request
Jul 14, 2022
OdNairy
pushed a commit
that referenced
this pull request
Jul 14, 2022
OdNairy
added a commit
that referenced
this pull request
Jul 14, 2022
* Update changelog (#1418) * Add style toggle to location example (#1413) * [XCParty] Add tag name if HEAD has any (#1424) * [XCParty] Export crash reports for XCResult (#1434) * Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431) * Add cast shadow option to 3d puck config (#1435) * Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440) * Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429) * Add option to support measurements from the only last run (#1445) * Update examples (#1443) * Fix flaky test (#1450) * Fix view annotation losing its feature association after update (#1446) * Enable `modelCastsShadow` option for custom location puck config (#1447) * enabled model casts shadows option for custom location puck configuration * Provide default value for list of last-run metrics (#1453) * Update CoreMaps to `10.7.0-rc.1` (#1456) * Update CoreMaps to 10.7.0-rc.1 * Update changelog * Update changelog header (#1459) * Update 10.7.0 versions (#1460) Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
OdNairy
added a commit
that referenced
this pull request
Jul 14, 2022
* Add style toggle to location example (#1413) * [XCParty] Add tag name if HEAD has any (#1424) * [XCParty] Export crash reports for XCResult (#1434) * Expose a way to initialise TilesetDescriptorOptionsForTilesets (#1431) * Add cast shadow option to 3d puck config (#1435) * Mark camera functions as unsupported for globe projection, invocation results in a no-op (#1440) * Rotation gesture threshold and simultaneousRotateAndPinchToZoomEnabled option (#1429) * Add option to support measurements from the only last run (#1445) * Update examples (#1443) * Fix flaky test (#1450) * Fix view annotation losing its feature association after update (#1446) * Enable `modelCastsShadow` option for custom location puck config (#1447) * enabled model casts shadows option for custom location puck configuration * Provide default value for list of last-run metrics (#1453) * Update CoreMaps to `10.7.0-rc.1` (#1456) * Update CoreMaps to 10.7.0-rc.1 * Update changelog * Update changelog header (#1459) * Update 10.7.0 versions (#1460) Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com> Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a public initialiser for
TilesetDescriptorOptionsForTilesets
.Pull request checklist:
Non-applicable.
## main
heading near the top).