Resolve initial view annotation placement issue #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maios
approved these changes
Sep 28, 2022
evil159
reviewed
Sep 28, 2022
…n when view annotations are added
|
Some tests are failing, could you check that? |
evil159
approved these changes
Oct 6, 2022
ZiZasaurus
deleted the
MAPSIOS-339-next-door-annotation-views-render-at-generic-location-on-creation-before-jumping-to-proper-coordinates
branch
OdNairy
pushed a commit
that referenced
this pull request
Oct 7, 2022
* resolving initial annotation view placement issue
OdNairy
pushed a commit
that referenced
this pull request
Oct 7, 2022
* resolving initial annotation view placement issue
OdNairy
added a commit
that referenced
this pull request
Oct 7, 2022
* Update GL-Native and Common versions * Update Maps version to 10.9.0-rc.1 * fix zh localization (#1602) * Write static config only if directory exists (#1608) * Write static config only if directory exists * Fix MapboxMaps -> MapboxMaps-static * Enable ASan, JUnit collection, fix e2e, store crashes (#1622) * Store crashes during unit tests * Use JUnit for unit tests * Fix e2e script on pushes without linked PR * Enable Address Sanitizer for tests * Resolve issue where selected view annotation is not moved to correct z-order (#1607) * fix issue where selected view annotation is not moved to correct z-order * Resolve initial view annotation placement issue (#1604) * resolving initial annotation view placement issue * Smooth reduced accuracy ring radius interpolation (#1625) Co-authored-by: Ankur Khandelwal <ankur.khandelwal@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
OdNairy
added a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the addition of view annotation to the containerView, which caused the view annotation to initially load in the top left corner.