Resolve issue where selected view annotation is not moved to correct z-order #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjleonard37
approved these changes
Sep 28, 2022
Tests/MapboxMapsTests/Annotations/ViewAnnotationManagerTests.swift
Outdated
Show resolved
Hide resolved
| try? manager.update(annotationViewA, options: ViewAnnotationOptions(selected: true)) | ||
| XCTAssertEqual(mapboxMap.addViewAnnotationStub.invocations.first?.parameters.id, "test-id") | ||
|
|
||
| // After adding a new annotation, the item clostst to the map is now furthest from the map |
There was a problem hiding this comment.
Suggested change
| // After adding a new annotation, the item clostst to the map is now furthest from the map | |
| // After adding a new annotation, the item closest to the map is now furthest from the map |
And here
The tests seem right, but the comments don't seem to align. Could you add context about what each step is looking for
maios
requested changes
Sep 29, 2022
There was a problem hiding this comment.
correct me if I'm wrong but the order of the views is decided in DelegatingViewAnnotationPositionsUpdateListenerDelegate, upon receiving changes in view annotations (adding/removing/updating), mapboxMap will notify its delegate about new placement of annotation views. I think the test should setup similar to this test below
Tests/MapboxMapsTests/Annotations/ViewAnnotationManagerTests.swift
Outdated
Show resolved
Hide resolved
…wift Co-authored-by: Patrick Leonard <pjleonard37@users.noreply.github.com>
evil159
reviewed
Oct 3, 2022
Tests/MapboxMapsTests/Annotations/ViewAnnotationManagerTests.swift
Outdated
Show resolved
Hide resolved
maios
approved these changes
Oct 5, 2022
evil159
approved these changes
Oct 5, 2022
ZiZasaurus
deleted the
MAPSIOS-381-selected-view-annotation-doesnt-render-on-top
branch
OdNairy
pushed a commit
that referenced
this pull request
Oct 7, 2022
…z-order (#1607) * fix issue where selected view annotation is not moved to correct z-order
OdNairy
pushed a commit
that referenced
this pull request
Oct 7, 2022
…z-order (#1607) * fix issue where selected view annotation is not moved to correct z-order
OdNairy
added a commit
that referenced
this pull request
Oct 7, 2022
* Update GL-Native and Common versions * Update Maps version to 10.9.0-rc.1 * fix zh localization (#1602) * Write static config only if directory exists (#1608) * Write static config only if directory exists * Fix MapboxMaps -> MapboxMaps-static * Enable ASan, JUnit collection, fix e2e, store crashes (#1622) * Store crashes during unit tests * Use JUnit for unit tests * Fix e2e script on pushes without linked PR * Enable Address Sanitizer for tests * Resolve issue where selected view annotation is not moved to correct z-order (#1607) * fix issue where selected view annotation is not moved to correct z-order * Resolve initial view annotation placement issue (#1604) * resolving initial annotation view placement issue * Smooth reduced accuracy ring radius interpolation (#1625) Co-authored-by: Ankur Khandelwal <ankur.khandelwal@mapbox.com> Co-authored-by: Mai Mai <mai.mai@mapbox.com> Co-authored-by: ZiZi <44972592+ZiZasaurus@users.noreply.github.com> Co-authored-by: Roman Laitarenko <roman.laitarenko@mapbox.com>
persidskiy
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Make internal map to conform to UIViewControllerRepresentable * Wrap SwiftUI view annotation to UIKit. * Support dynamic sizing for view annotations
OdNairy
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Make internal map to conform to UIViewControllerRepresentable * Wrap SwiftUI view annotation to UIKit. * Support dynamic sizing for view annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1599
Pull request checklist:
custom_categories(scripts/doc-generation/.jazzy.yaml)## mainheading near the top).v10.[version]release branch fix / enhancement, merge it tomainfirst and then port tov10.[version]release branch.PRs must be submitted under the terms of our Contributor License Agreement CLA.