-
Notifications
You must be signed in to change notification settings - Fork 320
Reinitialize route line layers every time initialize is called. #6793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de2f25e
to
3ba04b4
Compare
cb71365
to
33a1383
Compare
Codecov Report
@@ Coverage Diff @@
## main #6793 +/- ##
============================================
+ Coverage 72.93% 72.98% +0.04%
- Complexity 5662 5667 +5
============================================
Files 786 786
Lines 30456 30505 +49
Branches 3607 3607
============================================
+ Hits 22214 22263 +49
Misses 6810 6810
Partials 1432 1432
|
101fb7c
to
e9e1363
Compare
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Show resolved
Hide resolved
9d45d3f
to
14a7396
Compare
ChangelogFeatures
Bug fixes and improvementsFixed "global reference table overflow" in case an application accumulates and keeps links to
Known issues
|
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/route/line/api/MapboxRouteLineView.kt
Outdated
Show resolved
Hide resolved
…ptions even if it means removing the existing layers.
14a7396
to
9905db4
Compare
In the interest of pushing this work forward I updated the PR with a minimal set of changes needed to resolve the issue reported upstream. If we want to consider expanding the API surface, let's discuss this separately. |
Description
When the
MapboxRouteLineView::initializeLayers
is called any existing route line related layers will be removed and the layers will be re-added with the current options. Previously the layers would only be initialized if they previously didn't exist. CallinginitializeLayers
will always result in the same map state with regard to the layers related to the route line.Screenshots or Gifs