This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Reverse Geocoding #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some fwd->forward terminology cleanup
| @click.option('--access-token', help="Your access token") | ||
| @click.option('--forward', default=False, help="Perform a forward geocode") | ||
| @click.option('--reverse', default=False, help="Perform a reverse geocode") |
There was a problem hiding this comment.
We can combine these into one boolean option like
@click.option('--forward/--reverse', default=True, help="Perform a forward (default) or reverse geocode")
and remove lines 29-33.
|
Looking good to me! I'm 👍 on changing the method to |
|
that sounds great to me. merging... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would love some 👀 @sgillies @dnomadb. Biggest change is an alteration to the command line interface to make
clickhandle passed coordinates with as little ugliness as possible.