Buffered Query Resolution Fix #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly transformed unbuffered extented that was required for vector tile creation.
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=======================================
Coverage 60.01% 60.01%
=======================================
Files 30 30
Lines 2111 2111
=======================================
Hits 1267 1267
Misses 844 844
Continue to review full report at Codecov.
|
|
noting this reverts this test fixture change as well: 6ec57f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for incorrectly using buffered query extent when it was simply a correctly transformed unbuffered extended that was required for vector tile creation.
In a most basic sense the changes associated with #233 were slightly incorrect as the resolution was based on the buffered area rather then the unbuffered area for the query. This was causing issues with assumptions around tile_width and pixel_width in some calculations.
/cc @lukasmartinelli @springmeyer