Data team peer review 5/30-6/03

[karitotp]

Last peer review ticket: #188

Mapping projects to be reviewed

1. Turn Restriction Mapping
2. Turn Lanes Mapping
3. To-fix: Unconnected major highways
4. To-fix: Unconnected minor highways
5. To-fix: Overlapping major highways
6. To-fix: Overlapping minor highways
7. To-fix: Crossing major highways
8. To-fix: Crossing minor highways
9. To-fix: Kinks major highways
10. To-fix: Kinks minor highways
11. To-fix: Island major highways
12. To-fix: Island minor highways
13. To-fix: Tiger Delta
14. To-fix: Invalid turnlanes
15. Hometown mapping

Instructions

• Download .osm files for last week.
  • 2016-05-30
  • 2016-05-31
  • 2016-06-01
  • 2016-06-02
  • 2016-06-03
• Select any date and extract the files.
• Each team member will have an osm file of edits during the respective date, for example: 2016-04-20-andygol.osm. Select any .osm file and open the data in JOSM.
• If no edits were done during that day, JOSM will notify that no data was exist, load another file.

• Examine user edits in detail. In JOSM, select a random small area edited by the user and press 3 to zoom.
• Download the latest data in OSM as a new layer and add a filter Cmd + F to see only the user's edits, e.g. user:andygol.

• Select a way/node and load the the history (Ctrl + H), the changeset comment will describe what specific project the user was working on.
• To get an OSM link to the object, click Cmd + Shift + H.
• Note down any feedback for each user in this ticket or comment directly in the changeset. Use this format:

username
changeset link - issue to fix

• @karitotp or @chtnha will post the feedback in the ticket (Use Github handle because OSM name is different from Github name) and make necessary changes on the same day.
• Close the ticket once user's have fixed their edits.

For clarifications, discuss with the @mapbox/team-data in this ticket.

[samely]

I think something could be wrong because I was reviewing @dannykath editions, but I had @luiswalter editions instead.

@Rub21 Can you check what happened?

[karitotp]

@planemad

Crossing building

• https://www.openstreetmap.org/way/422662116/history

[karitotp]

@ridixcr

Untagged ways

• https://www.openstreetmap.org/way/422067537/history

Delete turn lane

• https://www.openstreetmap.org/way/49782769/history
• https://www.openstreetmap.org/way/422102751/history
• https://www.openstreetmap.org/way/422103067/history, along the highway
• https://www.openstreetmap.org/way/422102133/history
• https://www.openstreetmap.org/way/422101169/history
• https://www.openstreetmap.org/way/422101177/history
• https://www.openstreetmap.org/way/422100958/history
• https://www.openstreetmap.org/way/422100314/history
• https://www.openstreetmap.org/way/422100311/history
• https://www.openstreetmap.org/way/422100313/history, along the highway
• https://www.openstreetmap.org/way/422102774/history
• https://www.openstreetmap.org/way/40938959/history

Connect the streets

• https://www.openstreetmap.org/node/1612179192/history
• https://www.openstreetmap.org/way/422705657/history

Missing turn lanes

• https://www.openstreetmap.org/node/3911738531/history
• https://www.openstreetmap.org/way/8740295/history

Number of lanes wrong

• https://www.openstreetmap.org/way/257571035/history, along the highway
• https://www.openstreetmap.org/way/422074868/history
• https://www.openstreetmap.org/way/422081989/history, along the highway
• https://www.openstreetmap.org/way/422040558/history
• https://www.openstreetmap.org/way/422040491/history
• https://www.openstreetmap.org/way/422040494/history
• https://www.openstreetmap.org/way/422081990/history
• https://www.openstreetmap.org/way/421882374/history fix number in the turn:lanes
• https://www.openstreetmap.org/way/421862005/history
• https://www.openstreetmap.org/way/421881054/history
• https://www.openstreetmap.org/way/62207281/history
• https://www.openstreetmap.org/way/420885182/history
• https://www.openstreetmap.org/way/421879008/history
• https://www.openstreetmap.org/way/421881054/history
• https://www.openstreetmap.org/way/421887189/history

Wrong turn:lanes

• https://www.openstreetmap.org/way/421818111/history

Fix starting point of turn:lanes

• https://www.openstreetmap.org/way/421854005/history // edicion de ridixcr

[karitotp]

@piligab

Untagged ways

• https://www.openstreetmap.org/way/422476918/history
• https://www.openstreetmap.org/way/422476919/history
• https://www.openstreetmap.org/way/422483551/history
• https://www.openstreetmap.org/way/422487048/history
• https://www.openstreetmap.org/way/422510006/history
• https://www.openstreetmap.org/way/422264262/history

Improve the alignment of the street

• https://www.openstreetmap.org/way/422683842/history
• https://www.openstreetmap.org/way/16430649/history
• https://www.openstreetmap.org/way/23899578/history
• https://www.openstreetmap.org/way/22733929/history

In this case only align or trace the street if it matches the satellite image

• https://www.openstreetmap.org/way/14583525/history

Unnamed ways, you should add the name displayed in the tiger layer

• https://www.openstreetmap.org/way/422280799/history
• https://www.openstreetmap.org/way/422228503/history
• https://www.openstreetmap.org/way/422222826/history

Change the tag highway=road for highway=unclassified

• https://www.openstreetmap.org/way/422689868/history

Add layer=1 to the bridge

• https://www.openstreetmap.org/way/129015728/history
• https://www.openstreetmap.org/way/422703219/history
• https://www.openstreetmap.org/way/115820497/history
• https://www.openstreetmap.org/way/196644015/history

[karitotp]

@Yurasi

Untagged ways

• https://www.openstreetmap.org/way/422254348/history
• https://www.openstreetmap.org/way/422485565/history
• https://www.openstreetmap.org/way/422490465/history
• https://www.openstreetmap.org/way/422667726/history
• https://www.openstreetmap.org/way/422668066/history
• https://www.openstreetmap.org/way/422668920/history
• https://www.openstreetmap.org/way/422694952/history
• https://www.openstreetmap.org/way/422698558/history

Improve the alignment of the street

• https://www.openstreetmap.org/way/422281746/history
• https://www.openstreetmap.org/way/422698558/history

Incorrect assignment of turning_circle tag

• https://www.openstreetmap.org/node/298038223/history

Change the tag highway=road for highway=residential

https://www.openstreetmap.org/way/124989810/history

[karitotp]

@calfarome

Fix starting point of turn:lanes

• https://www.openstreetmap.org/way/416081595/history

oneway=yes together with turn:lanes:*

• https://www.openstreetmap.org/way/421859855/history

[karitotp]

@karitotp

Wrong number of lanes

• https://www.openstreetmap.org/way/421887189/history
• https://www.openstreetmap.org/way/421879008/history

[karitotp]

@luiswalter

Trace two lanes

• https://www.openstreetmap.org/way/422649592/history
• https://www.openstreetmap.org/way/422649594/history
• https://www.openstreetmap.org/way/422649593/history

Number of lanes wrong

• https://www.openstreetmap.org/way/422729738/history
• https://www.openstreetmap.org/way/422729732/history
• https://www.openstreetmap.org/way/422720564/history

Wrong turn:lanes tags

https://www.openstreetmap.org/way/42121221/history

[karitotp]

@poornibadrinath

Move the starting point until the physical separation and add turn:lanes to the road.

• https://www.openstreetmap.org/way/421798813/history
• https://www.openstreetmap.org/way/421793696/history

Missing highway tag

• https://www.openstreetmap.org/way/421800287/history

[karitotp]

@RichRico

Wrong number of lanes

• https://www.openstreetmap.org/way/421879008/history

Wrong turn:lanes tag

• https://www.openstreetmap.org/way/421878088/history
• https://www.openstreetmap.org/way/421878088/history
• https://www.openstreetmap.org/way/42121221/history

[piligab]

@karitotp Thank you for the correction. I corrected errors.

Untagged ways

• https://www.openstreetmap.org/way/422476918/history
  • https://www.openstreetmap.org/changeset/39892032
• https://www.openstreetmap.org/way/422476919/history
  • https://www.openstreetmap.org/changeset/39892449
• https://www.openstreetmap.org/way/422483551/history
  • https://www.openstreetmap.org/changeset/39892517
• https://www.openstreetmap.org/way/422487048/history
  • https://www.openstreetmap.org/changeset/39892607
• https://www.openstreetmap.org/way/422510006/history
  • https://www.openstreetmap.org/changeset/39892672

Improve the alignment of the street

• https://www.openstreetmap.org/way/422683842/history
  • https://www.openstreetmap.org/changeset/39892857
• https://www.openstreetmap.org/way/16430649/history
  • https://www.openstreetmap.org/changeset/39892932
• https://www.openstreetmap.org/way/23899578/history
  • https://www.openstreetmap.org/changeset/39892857
• https://www.openstreetmap.org/way/22733929/history
  • https://www.openstreetmap.org/changeset/39893110

In this case only align or trace the street if it matches the satellite image

• https://www.openstreetmap.org/way/14583525/history
  • https://www.openstreetmap.org/changeset/39893339

Unnamed ways, you should add the name displayed in the tiger layer

• https://www.openstreetmap.org/way/422280799/history
  • https://www.openstreetmap.org/changeset/39893458
• https://www.openstreetmap.org/way/422228503/history
  • https://www.openstreetmap.org/changeset/39893614
• https://www.openstreetmap.org/way/422222826/history
  • https://www.openstreetmap.org/changeset/39893564

Change the tag highway=road for highway=unclassified

• https://www.openstreetmap.org/way/422689868/history
  • https://www.openstreetmap.org/changeset/39893698

Add layer=1 to the bridge

• https://www.openstreetmap.org/way/129015728/history
  • https://www.openstreetmap.org/changeset/39893798
• https://www.openstreetmap.org/way/422703219/history
  • https://www.openstreetmap.org/changeset/39893842
• https://www.openstreetmap.org/way/115820497/history
  • https://www.openstreetmap.org/changeset/39893873
• https://www.openstreetmap.org/way/196644015/history
  • https://www.openstreetmap.org/changeset/39893939

[calfarome]

Thanks for the feedback team

Fix starting point of turn:lanes

• https://www.openstreetmap.org/way/416081595/history

oneway=yes together with turn:lanes:*

• https://www.openstreetmap.org/way/421859855/history

[karitotp]

Thanks for the feedback team!

They aren't my editions, but I've already fixed them. Here are my changeset.

Wrong number of lanes

• https://www.openstreetmap.org/changeset/39895610
• https://www.openstreetmap.org/changeset/39895656

[Yurasi]

THanks for the feedback team.

Here are my changeset.

Untagged ways

• https://www.openstreetmap.org/changeset/39895389
• https://www.openstreetmap.org/changeset/39895442
• https://www.openstreetmap.org/changeset/39895492
• https://www.openstreetmap.org/changeset/39895518
• https://www.openstreetmap.org/changeset/39895538
• https://www.openstreetmap.org/changeset/39895556
• https://www.openstreetmap.org/changeset/39895607
• https://www.openstreetmap.org/changeset/39895629

Improve the alignment of the street

• https://www.openstreetmap.org/changeset/39895750
• https://www.openstreetmap.org/changeset/39895854

Incorrect assignment of turning_circle tag

• https://www.openstreetmap.org/changeset/39895875

Change the tag highway=road for highway=residential

• https://www.openstreetmap.org/changeset/39895924

[ridixcr]

Thanks for the feedback team

Untagged ways

• https://www.openstreetmap.org/changeset/39896024

Delete turn lane

• https://www.openstreetmap.org/changeset/39896100
• https://www.openstreetmap.org/changeset/39896132
• https://www.openstreetmap.org/changeset/39896151
• https://www.openstreetmap.org/changeset/39896160
• https://www.openstreetmap.org/changeset/39896171
• https://www.openstreetmap.org/changeset/39896186
• https://www.openstreetmap.org/way/422100958/history - not an error
• https://www.openstreetmap.org/changeset/39896251
• https://www.openstreetmap.org/changeset/39896261
• https://www.openstreetmap.org/changeset/39896280
• https://www.openstreetmap.org/changeset/39896305
• https://www.openstreetmap.org/changeset/39896320

Connect the streets

• https://www.openstreetmap.org/changeset/39896427
• https://www.openstreetmap.org/changeset/39896450

Missing turn lanes

• https://www.openstreetmap.org/changeset/39896476
• https://www.openstreetmap.org/changeset/39896489

Wrong turn:lanes

• https://www.openstreetmap.org/changeset/39896521

Fix starting point of turn:lanes

• https://www.openstreetmap.org/changeset/39896534

Number of lanes wrong

• https://www.openstreetmap.org/changeset/39909685,fixed along the highway
• https://www.openstreetmap.org/changeset/39910251,fixed along the highway
• https://www.openstreetmap.org/changeset/39910311
• https://www.openstreetmap.org/changeset/39910339
• https://www.openstreetmap.org/changeset/39910373
• https://www.openstreetmap.org/changeset/39910403
• https://www.openstreetmap.org/changeset/39910432
• https://www.openstreetmap.org/changeset/39910453
• https://www.openstreetmap.org/changeset/39910485
• https://www.openstreetmap.org/changeset/39910509
• https://www.openstreetmap.org/changeset/39910534
• https://www.openstreetmap.org/way/421881054/history - not an error

[poornibadrinath]

@karitotp Thank you for the feedback

Untagged highways

https://www.openstreetmap.org/changeset/39899739

We have not worked on turn lanes in Phoenix yet.

These roads:
https://www.openstreetmap.org/way/421798813/history
https://www.openstreetmap.org/way/421793696/history

were added during the turn restriction task for the restriction u turns and missing ways. Will work on adding turn lanes during the Phoenix turn lane task.

[RichRico]

Thanks for the feedback

Wrong turn:lanes tag

https://www.openstreetmap.org/changeset/39943388
https://www.openstreetmap.org/changeset/39937497

[planemad]

@karitotp sharp 👀 ! Fixed https://www.openstreetmap.org/changeset/40010724

[luiswalter]

Thanks for the feedback

Trace two lanes

https://www.openstreetmap.org/way/424933025/history

Number of lanes wrong

• https://www.openstreetmap.org/way/422729738/history No error
• https://www.openstreetmap.org/way/422729732/history No error
• https://www.openstreetmap.org/way/422720564/history No error

Wrong turn:lanes tags

https://www.openstreetmap.org/way/42121221/history No error

[karitotp]

Thanks everyone!