Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metrics #3446

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Add new metrics #3446

merged 10 commits into from
Oct 9, 2024

Conversation

sebr72
Copy link
Contributor

@sebr72 sebr72 commented Sep 30, 2024

Timers to record different entry points

@sebr72 sebr72 marked this pull request as ready for review September 30, 2024 12:13
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just relay not sure if that's a good idea to separate the no app id!

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I passed the metric names in review and proposed some changes :-)

@sbrunner sbrunner self-requested a review October 9, 2024 11:24
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I steal, don't like doing so many things in the health check!

@sebr72 sebr72 merged commit 8b53948 into master Oct 9, 2024
9 checks passed
@sebr72 sebr72 deleted the metrics-requests branch October 9, 2024 14:09
@geo-ghci-int geo-ghci-int bot added this to the 3.31.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants