-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new metrics #3446
Add new metrics #3446
Conversation
0b40028
to
652ae4a
Compare
2720f92
to
40e026f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just relay not sure if that's a good idea to separate the no app id!
core/src/main/java/org/mapfish/print/servlet/job/impl/ThreadPoolJobManager.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/servlet/job/HibernateAccounting.java
Outdated
Show resolved
Hide resolved
aaa0fbb
to
5a739e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I passed the metric names in review and proposed some changes :-)
core/src/main/java/org/mapfish/print/servlet/job/HibernateAccounting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mapfish/print/metrics/ApplicationStatus.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I steal, don't like doing so many things in the health check!
Timers to record different entry points