Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix all class names with mapillary #343

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Prefix all class names with mapillary #343

merged 1 commit into from
Mar 15, 2021

Conversation

oscarlorentzon
Copy link
Member

Motivation

Make it clearer that classes belongs to the MapillaryJS library to avoid collisions.

Contribution

Prefixes all class names with mapillary-.

Test Plan

yarn prepare
yarn test
yarn start
  1. Manually test all components by visual inspecition.

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 15, 2021
@oscarlorentzon oscarlorentzon merged commit 7c9c7f9 into main Mar 15, 2021
@oscarlorentzon oscarlorentzon deleted the feature-css-naming-refactor branch March 15, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarlorentzon @facebook-github-bot