Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing data gracefully #368

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Handle missing data gracefully #368

merged 4 commits into from
Apr 23, 2021

Conversation

oscarlorentzon
Copy link
Member

Motivation

Provide understandable error messages when data is missing and only log relevant error information.

Contribution

  • Throw with informative message if image is not populated correctly
  • Throw with informative message if image thumb URL is not valid
  • Do not request mesh if URL is not valid
  • Avoid null reference error by checking for cluster existence

Test Plan

yarn lint
yarn build
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Apr 23, 2021
@oscarlorentzon oscarlorentzon merged commit e1ebee7 into main Apr 23, 2021
@oscarlorentzon oscarlorentzon deleted the feature-missing-data branch April 23, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants