Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer configuration as observables #441

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

oscarlorentzon
Copy link
Member

Avoid setting static properties which affects
all future Viewers created in the same app.
Use observables instead.

Motivation

Allow different image tiling configs for multiple viewers in the same app.

Contribution

  • Viewer configuration as a service with observables

Test Plan

yarn lint
yarn build
yarn test
yarn start

Avoid setting static properties which affects
all future Viewers created in the same app.
Use observables instead.
@oscarlorentzon oscarlorentzon added this to the v4.0.0 milestone Jun 10, 2021
@oscarlorentzon oscarlorentzon merged commit a1df915 into main Jun 10, 2021
@oscarlorentzon oscarlorentzon deleted the feature-viewer-config branch June 10, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants