Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth transition when entering earth state #501

Merged
merged 4 commits into from
Jan 30, 2022
Merged

Smooth transition when entering earth state #501

merged 4 commits into from
Jan 30, 2022
+108 −118

Conversation

oscarlorentzon
Copy link
Member

Motivation

Better understanding of the 3D space.

Contribution

  • Remove unit bezier dependency and use simpler smoothstep function for transitions instead.
  • Smoothly move the camera when entering earth state. Focus on ground.

Test Plan

yarn build
yarn test

@oscarlorentzon oscarlorentzon added this to the v4.1.0 milestone Jan 30, 2022
@oscarlorentzon oscarlorentzon self-assigned this Jan 30, 2022
@oscarlorentzon oscarlorentzon changed the title Smooth transition to earth state Smooth transition when entering earth state Jan 30, 2022
@oscarlorentzon oscarlorentzon merged commit 091b80f into main Jan 30, 2022
@oscarlorentzon oscarlorentzon deleted the feature-smoothstep branch January 30, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscarlorentzon @facebook-github-bot