feat!: rename Maplibre to MapLibre
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
force-pushed
the
feat/rename-Mapbox-and-Maplibre-to-MapLibre
branch
from
9328b99 to
1f78968
Compare
kuhnroyal
reviewed
Jun 5, 2024
| @@ -1,6 +1,6 @@ | |||
| part of '../maplibre_gl_platform_interface.dart'; | |||
|
|
|||
| class MethodChannelMaplibreGl extends MapLibreGlPlatform { | |||
| class MethodChannelMapLibreGl extends MapLibreGlPlatform { | |||
There was a problem hiding this comment.
Lets go with MapLibreGlMethodChannel for this?
There was a problem hiding this comment.
How about shorten it down to MapLibreMethodChannel? (and MapLibreGlPlatform to MapLibrePlatform)
There was a problem hiding this comment.
I don't mind, we have a mix of names with and without the gl suffix anyways.
kuhnroyal
approved these changes
Jun 5, 2024
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 6, 2024
We have currently a mix of `Maplibre` and `MapLibre`. This pull request changes all occurrences to `MapLibre` to be in line with the underlaying packages. I added deprecations for MaplibreMap, MaplibreMapController and MaplibreStyles to help users migrate.
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 10, 2024
We have currently a mix of `Maplibre` and `MapLibre`. This pull request changes all occurrences to `MapLibre` to be in line with the underlaying packages. I added deprecations for MaplibreMap, MaplibreMapController and MaplibreStyles to help users migrate.
Remi-deronzier
pushed a commit
to viamichelin/flutter-maplibre-gl
that referenced
this pull request
Sep 10, 2024
We have currently a mix of `Maplibre` and `MapLibre`. This pull request changes all occurrences to `MapLibre` to be in line with the underlaying packages. I added deprecations for MaplibreMap, MaplibreMapController and MaplibreStyles to help users migrate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have currently a mix of
MaplibreandMapLibre. This pull request changes all occurrences toMapLibreto be in line with the underlaying packages.I added deprecations for MaplibreMap, MaplibreMapController and MaplibreStyles to help users migrate.