Skip to content

Hotfixes #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2019
Merged

Hotfixes #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09de692
Merge branch 'dev'
Nov 13, 2019
dc55b71
use onCreate for counter function #234
Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions firebase/functions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,9 @@ admin.initializeApp()
// Increments or Decrements various counter
//
// Gets triggered when new results of the group are written to the database.
exports.counter = functions.database.ref('/v2/results/{projectId}/{groupId}/{userId}/').onWrite((snapshot, context) => {
// if result ref does not contain any data
// (e.g. when deletion during transfer_results() occured)
// do nothing
if (!snapshot.after.exists()) {
return null
}

exports.counter = functions.database.ref('/v2/results/{projectId}/{groupId}/{userId}/').onCreate((snapshot, context) => {
const promises = []
const result = snapshot.after.val()
const result = snapshot.val()

// if result ref does not contain all required attributes we don't updated counters
// e.g. due to some error when uploading from client
Expand Down