Skip to content

Add project types as global var to definitions. #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2020
Merged

Add project types as global var to definitions. #261

merged 4 commits into from
Jan 13, 2020

Conversation

Matthias-Schaub
Copy link
Contributor

  • Add project types as global var to definitions.
  • Run Black.
  • Make use of PROJECT_TYPES in mapswipe_workers.py
  • Remove not needed imports in definitions.py and mapswipe_workers.py

Hagellach37
Hagellach37 reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@Hagellach37 Hagellach37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor changes required regarding project type names

mapswipe_workers/mapswipe_workers/definitions.py Outdated
}

PROJECT_TYPE_NAMES = {
1: BuildAreaProject.name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to use the correct attribute name here. For BuiltAreaProject class you use ProjectTypeName instead of name.

mapswipe_workers/mapswipe_workers/project_types/change_detection/change_detection_project.py Outdated
The subclass for an import of the type Footprint
"""

projectType = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the projectType for Change Detection should be 3and not 1.

@Matthias-Schaub Matthias-Schaub merged commit 0c29f5b into dev Jan 13, 2020
@Matthias-Schaub Matthias-Schaub deleted the project_types branch January 13, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hagellach37 Hagellach37 Hagellach37 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matthias-Schaub @Hagellach37