Use project type labels from projectTypes.ts #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses project type labels from config in TutorialList and ProjectDetails and removes redundant projectTypeLabelMap from utils/common.ts
…figuration uses more appropriate labels for more generic webapp version project types
ofr1tz
changed the base branch from
dev
to
refactor-new-project-view-manager-dashboard
ofr1tz
requested review from
ElJocho
and removed request for
a team and
Hagellach37
ElJocho
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #611, the available project types are configurable. However, project type labels in TutorialList and ProjectDetails are still imported from utils/common.ts.
This PR fixes this issue by using the labels from projectTypes.ts instead and by removing the thus redundant projectTypeLabelMap.
It also introduces appropriate labels for the more generic webapp configuration project types and uses the more explicit value "webapp" instead of "crowdmap" to configure the project types for use of the manager dashboard with the web application. An example entry with explanation is added to .env.example.