-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TileLayer support only load tiles in mask #2333
Conversation
@@ -52,7 +53,8 @@ const options: LayerOptionsType = { | |||
'collisionScope': 'layer', | |||
'hitDetect': (function () { | |||
return !Browser.mobile; | |||
})() | |||
})(), | |||
'maskClip': true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
mask不在是单纯的剪裁了,也可能用于tile filter
- maskClip 开启剪裁
一切交给用户来决定
总体没什么问题,但有几个可能的优化点:
|
问题已经解决 @fuzhenn |
关于
综上,上述四种情况似乎并没有带来很明显的业务灵活性,所以我建议去掉这两个设置,只要setMask,就相当于maskClip和onlyLoadTilesInMask生效。 |
我仔细想了下 onlyLoadTilesInMask可以去掉,但是maskClip得保留 |
fix #2332