Stateful find me button #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tap to activate find me button. While activated map will remain centered on current location. Tap again or pan map to deactivate. * Removes `locationRequested` boolean flag from `OverlayManager`. * Adds activated state to find me button. * Center map on location update only if find me is active. * Un-mock class under test in `OverlayManagerTest`. * Re-restrict scope on private constant value `NAME_CURRENT_LOCATION`. * Suppress visibility modifier checkstyle check for test classes. * Moves inner test classes to bottom of `MapzenMapTest`. * Adds internal pan responder to `MapzenMap`. * Forwards pan and fling events to both external listener and `OverlayManager`. * Deactivates find me button on map pan or fling. Closes mapzen/eraser-map#536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tap to activate find me button. While activated map will remain centered on current location. Tap again or pan map to deactivate.
locationRequestedboolean flag fromOverlayManager.OverlayManagerTest.NAME_CURRENT_LOCATION.MapzenMapTest.MapzenMap.OverlayManager.Closes mapzen/eraser-map#536