Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This updates
MapzenMap
,MapzenSearch
, andMapzenRouter
to use a new base implementation ofGenericHttpHandler
to send a custom User-Agent for all requests. The User-Agent is in the format<sdk_name>;<sdk_version>;<os_version>
. So for example,android-sdk;1.4.1-SNAPSHOT;7.1.2
. It also begins work to simplify & standardize how developers customize query parameters and headers sent for requests.Proposed Changes
GenericHttpHandler
interface to standardize how implementing developers customize requests (future work will expand this interface Expand GenericHttpHandler #410, Allow setting GenericHttpHandler on Mapzen API objects #411). Currently developers need to access the underlying Pelias/Tangram/Valhalla API object and set a subclass of that object's http handler. Each object has a slightly different api which is less than idealTmpHttpHandler
to allow setting headers in tile requests (will be removed when related Tangram work is completed Remove TmpHttpHandler #409)GenericHttpHandler
for allMapzenMap
,MapzenSearch
, andMapzenRouter
APIsCloses #382