Fix compilation on windows #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maranget
reviewed
Jun 27, 2024
check402.ml
Outdated
| @@ -1,6 +1,7 @@ | |||
| let () = | |||
| set_binary_mode_out stdout; | |||
There was a problem hiding this comment.
Hi @hhugo, thanks for submitting this PR. This code triggers the following warning at compilation:
set_binary_mode_out stdout;
^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning 5 [ignored-partial-application]: this function application is partial,
Could you motivate your change,? I know very little about Windows. Moreover, using text mode for I/O would, in my naive view, be more compatible that binary I/O.
There was a problem hiding this comment.
Sorry, it was a half a change from a previous iteration.
The issue with the script is that in presence of automatic newline translation on windows, the check in handle402.sh fail because there is now a trailing \r.
To fix it, one need to either set binary_mode for stdout or remove the newline (which this PR implement)
maranget
added a commit
that referenced
this pull request
Jul 4, 2024
|
PR merged by hand for a clean history, thanks @hhugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.