Added __debugInfo with human readable properties to EnumSet & EnumMap #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdreesen
reviewed
Apr 5, 2020
| */ | ||
| public function __debugInfo(): array { | ||
| $dbg = (array)$this; | ||
| $dbg["\0" . self::class . "\0__pairs"] = array_map(function ($k, $v) { |
There was a problem hiding this comment.
Shouldn't this be static::class instead because the class is not final?
There was a problem hiding this comment.
No, because this is debug information only and it should not make the impression to access this.
Adding it as private property of the base class shows it's impossible to access (at least without reflection/closure).
There was a problem hiding this comment.
Ah, I understand, thx for the clarification :)
prolic
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnumSet: Add virtual private property "__enumerators" with a list of enumerator values set to the result of var_dump. This helps debugging as internally the enumerators of this EnumSet gets stored as either integer or binary bit-array.
EnumMap: Add virtual private property "__pairs" with a list of key-value-pairs to the result of var_dump. This helps debugging as internally the map is using the ordinal number.