Skip to content

Conversation

marc-mabe
Copy link
Owner

No description provided.

@marc-mabe marc-mabe force-pushed the fix-sleep-wakeup-deprecation branch from 88cde8a to 61a7e8c Compare September 14, 2025 09:57
@marc-mabe marc-mabe force-pushed the fix-sleep-wakeup-deprecation branch from 61a7e8c to 88bfcf0 Compare September 14, 2025 09:59
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (7159809) to head (88bfcf0).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #163      +/-   ##
============================================
- Coverage     99.47%   98.78%   -0.69%     
- Complexity      224      226       +2     
============================================
  Files             4        4              
  Lines           574      578       +4     
============================================
  Hits            571      571              
- Misses            3        7       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this looks good, IIUC PHP will call the serialize method instead of sleep if available, so that should address the 8.5 warning.

@marc-mabe marc-mabe merged commit bb426fc into master Sep 14, 2025
9 checks passed
@marc-mabe marc-mabe deleted the fix-sleep-wakeup-deprecation branch September 14, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants