EnumSet: added methods union(), intersect(), diff() and symDiff() #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
force-pushed
the
enumset_produce
branch
2 times, most recently
from
96efed1 to
3d5c3d7
Compare
marc-mabe
force-pushed
the
enumset_produce
branch
from
3d5c3d7 to
ac9aa5b
Compare
marc-mabe
changed the title
|
@prolic Would you like to review ? |
|
looks good, except I would make use of variadic function and bump minimum PHP version to 5.6. |
prolic
reviewed
Oct 5, 2016
| * @param EnumSet ...$other Other EnumSet(s) of the same enumeration to produce the union | ||
| * @return EnumSet | ||
| */ | ||
| public function union(EnumSet $other) |
There was a problem hiding this comment.
let's bump minimum required PHP version to 5.6 for this new feature and make use of variadic functions:
EnumSet::union(EnumSet ...$others)
oldschool PHP < 5.6 users can use the older version of this lib as is
|
I created an issue #69 for next major which allows BC break including bumb min PHP version. This PR tags 2.3.0. Anyway thanks for review !!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #62
These methods create a clone of
$thisand change the bitset to not depend on implementation details of extended classes.EnumSet::union(EnumSet ...$others) : EnumSetEnumSet::intersect(EnumSet ...$others) : EnumSetEnumSet::diff(EnumSet ...$others) : EnumSetEnumSet::symDiff(EnumSet ...$others) : EnumSet