Skip to content

optimized EnumSet::count() #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2016
Merged

optimized EnumSet::count() #67

merged 1 commit into from
Oct 3, 2016

Conversation

marc-mabe
Copy link
Owner

Bench

Before

$ php bench.php 
empty set count(): 0.14792680740356ms
full set count() : 0.13878393173218ms

After

$ php bench.php 
empty set count(): 0.0060579776763916ms
full set count() : 0.10427093505859ms

@marc-mabe marc-mabe added this to the 2.3.0 milestone Oct 1, 2016
prolic
prolic reviewed Oct 1, 2016
View reviewed changes
Copy link
Collaborator

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@marc-mabe marc-mabe merged commit 5a8feea into master Oct 3, 2016
@marc-mabe marc-mabe deleted the enumset_optimize_count branch October 3, 2016 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prolic prolic prolic left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marc-mabe @prolic