Added additional check to Enum::is() to return TRUE … #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-mabe
force-pushed
the
Enum_is_unserialized
branch
from
53e5104 to
1b550d1
Compare
|
@prolic @delbertooo This PR is updating the method |
prolic
reviewed
Dec 4, 2016
| $enum2 = unserialize(serialize($enum1)); | ||
|
|
||
| $this->assertFalse($enum1 === $enum2, 'Wrong test implementation'); | ||
| $this->assertTrue($enum1->is($enum2), 'Two different instances of exact the same enumerator shoulw be equal'); |
|
Nice! |
marc-mabe
force-pushed
the
Enum_is_unserialized
branch
from
1b550d1 to
1ee4865
Compare
…merators are the same but of different instances. This can happen because of the issue with serializable singletons
marc-mabe
force-pushed
the
Enum_is_unserialized
branch
from
1ee4865 to
0c9a7f7
Compare
|
fixed typo and updated documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in cases both enumerators are the same but of different instances. This can happen because of the issue with serializable singletons