Add a Drone CI service #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @marcells, did you have time to take a look at it ? |
marcells
approved these changes
Oct 1, 2019
|
Hi, sorry, that it took so long. Thanks for your PR supporting a new service. 👍 |
|
Thanks for the review and merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As DroneCI 1.0 breaks the compatibility with drone-wall, I think that's the occasion to allow Drone user to migrate to this project.
I created this service to request the Drone > 1.0 API.
One improvement I plan for soon is to listen the /stream endpoint to listen for change instead of doing the requests every X seconds. But this needs some deeper changes, so I prefer to submit two separate Pull Requests.