added bridgelist action, event and tests for it #157
+25,076
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! :) A small comment before accepting: I see there are some changes that don't look related (docblock updates, vars/args names), these might be fine but make this pr unnecessary big. Please open separate PRs for those so we can track the changes better. |
|
Sorry, but I have no idea how I could split this PR to the few PR. Those changes were made for phing builder because some variable names in phpdoc block differed from those which was used in methods. |
dkgroot
added a commit
to chan-sccp/PAMI
that referenced
this pull request
Apr 24, 2019
PR: marcelog#157 Provided by: @wizzle PR: Description: added bridgelist action, event and tests for it Adding A mix of Actions and Events Updating several comments / doc descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.