Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix castling and spelling of en passant #9 #11

Merged
merged 7 commits into from
Jan 7, 2018
Merged

Fix castling and spelling of en passant #9 #11

merged 7 commits into from
Jan 7, 2018

Conversation

ddugovic
Copy link
Contributor

Verified that O-O and O-O-O (using letters, not using zeroes) play correctly for both players.
Changed variable pessant to passant.
Added build/ and dist/ to .gitignore

@marcusbuffett
Copy link
Owner

This looks great! Thanks for the contribution. Just one question, what do the stringRep changes do? Unfortunately I’m not near a computer right now so I can’t run it to see the beautified version.

@ddugovic
Copy link
Contributor Author

ddugovic commented Dec 23, 2017

Thanks! This is the result of those stringRep changes (fewer coordinate markers and newlines are placed more intelligently):

It's your move. Type '?' for options. ? Nf3
Making move : Nf3

8  R N B Q K B N R
7  p p p p p p p p
6  
5  
4  
3            N
2  p p p p p p p p
1  R N B Q K B   R
                     
   a b c d e f g h

AI thinking...
Making move : b6

8  R N B Q K B N R
7  p   p p p p p p
6    p
5  
4  
3            N
2  p p p p p p p p
1  R N B Q K B   R
                     
   a b c d e f g h

It's your move. Type '?' for options. ? 

@marcusbuffett marcusbuffett merged commit ddb275c into marcusbuffett:master Jan 7, 2018
@ddugovic ddugovic deleted the fix_castling branch January 7, 2018 08:20
@ddugovic
Copy link
Contributor Author

ddugovic commented Jul 3, 2018

Oops, PGN specifies that the moves should be input as 0-0 and 0-0-0 (using numbers) but should be printed in a PGN file using letters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants