Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package versions in envinfo #1010

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: package versions in envinfo #1010

merged 2 commits into from
Mar 28, 2024

Conversation

akshayka
Copy link
Contributor

This PR uses importlib.metadata to get package versions for marimo env. This fixes a bug in which packages that were not imported before running marimo env had missing package versions.

importlib.metadata looks at Python's site-packages, so does not require any specific package manager to be installed.

This PR uses importlib.metadata to get package versions for marimo env.
This fixes a bug in which packages that were not imported before running
marimo env had missing package versions.

importlib.metadata looks at Python's site-packages, so does not require
any specific package manager to be installed.
@akshayka akshayka requested a review from mscolnick March 27, 2024 23:45
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 11:47pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 11:47pm

@akshayka akshayka merged commit ca254d6 into main Mar 28, 2024
29 checks passed
@akshayka akshayka deleted the aka/fix-envinfo branch March 28, 2024 15:48
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.3.6-dev3

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants